vscode-verilog-hdl-support icon indicating copy to clipboard operation
vscode-verilog-hdl-support copied to clipboard

[BUG] Module instantiation doesn't instantiate parameters

Open toTheSky opened this issue 10 months ago • 3 comments

Describe the bug Module instantiation instantiates ports but not parameters.

Environment (please complete the following information):

  • OS: Win 11
  • VS Code version 1.88.0
  • Extension version 1.13.5
  • ctags version v6.1.0 x64

Steps to reproduce Steps to reproduce the behavior:

  1. Run Command Palette
  2. Type and run "Verilog: Instantiate Module"
  3. Select Verilog of SystemVerilog file
  4. See error

Log I don't know where the log is located.

Expected behavior Parameters should be instantiated too.

Actual behavior Only ports are instantiated.

Additional context I tried to add additional arguments to ctags path (ctags.exe --fields-Verilog=+{parameter}) but it does't help.

toTheSky avatar Apr 10 '24 09:04 toTheSky

This is fixed on https://github.com/AndrewNolte/vscode-system-verilog. It'll also fill in the instantiation as you type 'Module #(, and it support interfaces

AndrewNolte avatar Apr 12 '24 19:04 AndrewNolte

This is fixed on https://github.com/AndrewNolte/vscode-system-verilog. It'll also fill in the instantiation as you type 'Module #(, and it support interfaces

Thanks. Can it be merged with the main repo?

toTheSky avatar Apr 20 '24 20:04 toTheSky

This is fixed on https://github.com/AndrewNolte/vscode-system-verilog. It'll also fill in the instantiation as you type 'Module #(, and it support interfaces

Thanks. Can it be merged with the main repo?

I forked off quite a bit to move faster with improvements, it's on the marketplace https://marketplace.visualstudio.com/items?itemName=AndrewNolte.vscode-system-verilog

AndrewNolte avatar Apr 24 '24 03:04 AndrewNolte

Hi, I am quite sure that this problem is caused by #102 between v1.13.0 and v1.13.1. The latest version without such problem is v1.13.0. This commit should probably be reverted?

RickyTino avatar Aug 12 '24 07:08 RickyTino

@toTheSky @RickyTino Can you test out the fix in #496? Thanks

Raamakrishnan avatar Aug 25 '24 12:08 Raamakrishnan

@Raamakrishnan

Thank you for your fix.

Now I see my fixes of #457 was correct, but I had to fix one more line.

hirooih avatar Aug 31 '24 01:08 hirooih