ical2org icon indicating copy to clipboard operation
ical2org copied to clipboard

added datetime into ID to split recurring zoom meetings

Open ajn2004 opened this issue 2 years ago • 2 comments

I noticed that google calendar keeps the same ID for repeating zoom meetings that happen in the same meeting room with the same title "i.e. daily standup/weekly all hands".
First event

BEGIN:VEVENT
DTSTART;TZID=<personal info>:20230726T183000
DTEND;TZID=<personal info>:20230726T190000
DTSTAMP:20230729T035734Z
ORGANIZER;CN=<personal info>
UID:A3D596EA-7CE5-4E6F-9218-C14C82061724
...
DESCRIPTION: <personal info> is inviting you to a scheduled Zoom meeting ...

Second Event

BEGIN:VEVENT
DTSTART;TZID=<personal info>:20230727T183000
DTEND;TZID=<personal info>:20230727T190000
DTSTAMP:20230729T035734Z
ORGANIZER;CN=<personal info>
UID:A3D596EA-7CE5-4E6F-9218-C14C82061724
...
DESCRIPTION: <personal info> is inviting you to a scheduled Zoom meeting ...

A quick glance at the DTSTART values show these are different events, but they contain the same UID, which will prevent them from both being recorded to the org file.

The change is simply to go from ID = UID ->ID> DSTART:UID which uniquely identifies the recurring event. In the above examples the change would be

old_id_first  = A3D596EA-7CE5-4E6F-9218-C14C82061724
old_id_second = A3D596EA-7CE5-4E6F-9218-C14C82061724

new_id_first  = 20230726T183000:A3D596EA-7CE5-4E6F-9218-C14C82061724
new_id_second = 20230727T183000:A3D596EA-7CE5-4E6F-9218-C14C82061724

This should have the advantage of discriminating between unique events and true duplicates, as true duplicates will also match their datetime and be excluded in the /^END:VEVENT/ logic.

ajn2004 avatar Jul 29 '23 13:07 ajn2004

Thank you for doing this! I haven't gotten a chance to look it over in depth yet, but at a glance it looks good. Do you know if this will lead to too many events in the org file or other unintended consequences? It's been a while since I've worked in this codebase and I'm a little rusty on it, unfortunately 😅

msherry avatar Aug 09 '23 06:08 msherry

I didn't see it making duplicates from events, but I didn't know how the original problem presented itself so I can't say I've tested against it. If an event has the same ID and date-time, it should not have a duplicate entry though, as it will have a duplicate ID and not be interacted with.

On Wed, Aug 9, 2023 at 2:17 AM Marc Sherry @.***> wrote:

Thank you for doing this! I haven't gotten a chance to look it over in depth yet, but at a glance it looks good. Do you know if this will lead to too many events in the org file or other unintended consequences? It's been a while since I've worked in this codebase and I'm a little rusty on it, unfortunately 😅

— Reply to this email directly, view it on GitHub https://github.com/msherry/ical2org/pull/11#issuecomment-1670736488, or unsubscribe https://github.com/notifications/unsubscribe-auth/AH7YRKVEVL6XRLNAIVHX3JDXUMTPPANCNFSM6AAAAAA24QSMZ4 . You are receiving this because you authored the thread.Message ID: @.***>

ajn2004 avatar Aug 09 '23 10:08 ajn2004