msgpack-python icon indicating copy to clipboard operation
msgpack-python copied to clipboard

Drop Python 2 support

Open sblondon opened this issue 2 years ago • 2 comments

According to pypi page, the python2 support has been dropped with release 1.0. The main branch in the repository is currently v.1.0.4 release (https://github.com/msgpack/msgpack-python/blob/main/msgpack/init.py#L9).

However, there is python2 specific code in the repository. For example:

  • setup.py checks for python2
  • msgpack/fallback.py could be simplified
  • python2 is checked in tox.ini
  • test/test_timestamp.py skip some tests with python2 (@pytest.mark.skipif(sys.version_info[0] == 2) ; test/test_extension.py has also a conditional

Are you interested by a PR to remove them?

sblondon avatar Sep 04 '22 21:09 sblondon

According to pypi page, the python2 support has been dropped with release 1.0.

image

Read it again.

methane avatar Sep 09 '22 07:09 methane

Are you interested by a PR to remove them?

pip dropped Python 2 support. So I will drop it too. I don't have actual plan for msgpack 1.1 or 2.0. But PR to remove them is welcome.

methane avatar Sep 09 '22 07:09 methane