msgpack-php icon indicating copy to clipboard operation
msgpack-php copied to clipboard

Msgpack serialize/unserialize support for APCu

Open ibobo opened this issue 8 years ago • 5 comments

Hi, I added support to use Msgpack as a serializer for APCu. This was needed to me because IgBinary is very unstable under PHP 7 (gives a Segmentation Fault whenever you try to use it as a session or APCu serializer) and I want to switch to the newer runtime version.

In the coming days I will do some more testing. If some of you have any suggestion on how to improve the pull request, I will be happy to fix it.

PS. I see the CI build fails for test 029 since it doesn't have APCu installed. Maybe I could add support for APC as well and update .travis.yml to use it. Let me know!

Thanks!

ibobo avatar Jul 04 '16 18:07 ibobo

Codecov Report

Merging #93 into master will decrease coverage by -0.25%.

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   87.19%   86.95%   -0.25%     
==========================================
  Files           8        8              
  Lines        1234     1234              
==========================================
- Hits         1076     1073       -3     
- Misses        158      161       +3
Impacted Files Coverage Δ
msgpack.c 92% <ø> (ø) :white_check_mark:
msgpack_unpack.c 85.49% <ø> (-0.91%) :x:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6472b9f...17bc8ca. Read the comment docs.

codecov-io avatar Jul 31 '16 22:07 codecov-io

TEST 30/123 [tests/029.phpt]
========DIFF========
005- APCu Serializer Support => enabled
========DONE========
FAIL Msgpack module info [tests/029.phpt] 

It looks like apu is not loaded when tests run

andypost avatar Jan 05 '19 20:01 andypost

Other failed tests are not compatible with PHP 7 https://github.com/msgpack/msgpack-php/pull/109

andypost avatar Jan 05 '19 20:01 andypost

Hi! Thanks for this submission.

Please rebase this PR, so we can have a closer look!

m6w6 avatar Dec 18 '19 16:12 m6w6

https://github.com/msgpack/msgpack-php/pull/162 still looking for reviews

andypost avatar Nov 11 '21 06:11 andypost