msgpack-javascript icon indicating copy to clipboard operation
msgpack-javascript copied to clipboard

Published 20 hours ago • verified publisher icon msgpack

Reuse Encoder/Decoder instance

Open buu700 opened this issue 3 years ago • 3 comments

Addresses #172

buu700 avatar May 05 '21 00:05 buu700

Thank you for the contribution. We need to make sure it's safe when we use this PR in the async/await context.

gfx avatar May 05 '21 00:05 gfx

Ah, right. It only changes the synchronous functions, although CI failed. It looks good.

Could you take a look at CI failure? I'll merge this PR if CI passes.

gfx avatar May 05 '21 01:05 gfx

Cool, sounds good. I'll investigate the failure as soon as I have a moment, but just rebased on the tip of main in case that makes a difference.

buu700 avatar May 05 '21 01:05 buu700