msgpack-haskell icon indicating copy to clipboard operation
msgpack-haskell copied to clipboard

Expose packing and unpacking primitives

Open nh2 opened this issue 12 years ago • 3 comments

I had to write some Packable and Unpackable instances for my own data structure and for this found the primitives in the package very useful. Unfortunately, they are not exposed, so that I had to copy-pasted them into my project.

This pull request exports:

  • fromString, fromArray, fromPair, fromMap from Data.MessagePack.Unpack
  • parseString, parseArray, parsePair, parseMap, parseUint16, parseUint32, parseUint64, parseInt8, parseInt16, parseInt32, parseInt64 from Data.MessagePack.Pack

It also adds Haddocks to all exported functions.

nh2 avatar Feb 01 '13 16:02 nh2

This seems reasonable to me, no reason not to expose functions if they might be of use to people. @tanakh, what do you think?

wmoss avatar Feb 05 '13 01:02 wmoss

Any update on this? It would be awesome to have it on hackage.

nh2 avatar Jun 13 '13 14:06 nh2

This still looks good to me. I can merge it into github, but I don't have the ability to put it on Hackage and it seems strange to have github master not track Hackage relatively closely. Sorry for the delay, I don't know where @tanakh, is.

wmoss avatar Jun 15 '13 02:06 wmoss