msgpack-cli icon indicating copy to clipboard operation
msgpack-cli copied to clipboard

Add public Packer PackBinary(byte[] array, int offset, int count)

Open HenrikFrystykNielsen opened this issue 7 years ago • 1 comments

First of all, thanks for a great library -- very nice!

My one suggestion is to add an overload on PackBinary that takes these parameters:

Packer PackBinary(byte[] array, int offset, int count)

This is in addition to the ones already there such as:

Packer PackBinary(byte[] value)

This makes it possible to create binary content using MemoryStream etc and not have to copy the array in order for PackBinary to use it. This is for example the case when using gzip'ed content in fluentd.

Thanks again!

Henrik

HenrikFrystykNielsen avatar May 22 '18 02:05 HenrikFrystykNielsen

It sounds great idea. Thanks!

yfakariya avatar Jun 05 '18 12:06 yfakariya