msgpack-c icon indicating copy to clipboard operation
msgpack-c copied to clipboard

Incorrect check: "MSVC doesn't support C++1x"

Open TheJoYo opened this issue 4 years ago • 1 comments

None of these ELSEIF ("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC") checks are actually checking if MSVC supports that dialect.

Example of this invalid check here

In this example, Visual Studio 2019 fails to build because of this check despite supporting C++17

TheJoYo avatar May 04 '20 18:05 TheJoYo

Yes, MSVC now also supports C++17. See Visual Studio 2017 15.7 Brings Full C++17 Compliance and Microsoft C++ language conformance table. But here still needs some testing.

ygj6 avatar May 08 '20 05:05 ygj6