Sean Gilligan
Sean Gilligan
Now that we are on Java 8+ and using `CompletableFuture` it is a little confusing to see a message that `throws CompletionException` when it is `Wallet.CompletionException` not `java.util.concurrent.CompletionException`. We should...
I'm pretty sure this is the right thing to do for `CompletionException`. I'm less sure for `IllegalArgumentException` and `IllegalStateException`. The `CompletionExceptions` cases need to be handled at runtime by wallet...
The `AddressParser` interface should have at least one provider look up method (that works with JDK 8 providers and in the future will work with JDK 9+ providers) Some possibilities:...
Currently the `wallettemplate` module depends upon FontAwesome (`'de.jensd:fontawesomefx:8.0.0'`) for two small icons: 1. The 'copy' icon (for copying the displayed Bitcoin address to the clipboard) 2. The 'QR code' icon...
This is a proof-of-concept for splitting the WalletTool into 2 classes: 1. WalletTool: args parsing with CLI, help/documentation, stdout/stderr, exit (with code) 2. WalletToolService: Wraps everything about wallet/peerGroup/store state into...
It looks like the major players in the JDK ecosystem are finally converging on a standard for nullability annotations. See: * https://jspecify.dev/docs/start-here * https://jspecify.dev/docs/api/org/jspecify/annotations/package-summary.html * https://github.com/jspecify/jspecify/wiki/adoption We need to keep...
Create an implementation and prepare a possible strategy to migrate from the default SPV client [BIP-0037](https://github.com/bitcoin/bips/blob/master/bip-0037.mediawiki) to [BIP-158](https://github.com/bitcoin/bips/blob/master/bip-0158.mediawiki) (Neutrino)
I am using **bitcoinj** 0.17-alpha1. If I remove the `.spvchain` file for a previously synced wallet and start up `WalletAppKit`, I get the following log output: ``` 15:59:21.820 [NioClientManager] INFO...
Rather than (if not segwit) simply add those unconnected outputs to the miner's fee, throw an IllegalArgumentException. In the case of segwit, the transaction can't be properly signed without knowing...
Neither the methods that take `Network` or the deprecated methods that take `NetworkParameters` are currently (directly, at least) tested.