Stefanos Mousafeiris comments

Results 95 comments of


                                            Stefanos Mousafeiris

In-flight requests crash when database is deleted

Opened https://github.com/electric-sql/electric/pull/2712 to address this - the root cause is that after the long poll timeout the request is being processed as if the stack is "active" and able to...

Move `stream.subscribe()` to be part of the constructor

I think we want this to be a declarative list of subscribers, soo something like: ```ts type ShapeStreamSubscriber = { onMessages: (messages: Message[]) => void | Promise, onError: (err: unknown)...

Move `stream.subscribe()` to be part of the constructor

> Is there not a slight chicken and egg thing of needing to instantiate a Shape to have the subscribers to instantiate the ShapeStream which is needed to instantiate the...

Move `stream.subscribe()` to be part of the constructor

@samwillis happy that it works with that pattern as well! (although I'm unclear if the `comments` builder `.run()` call would also "build" the `issues` stream as well - i.e. "deep...

Move `stream.subscribe()` to be part of the constructor

@samwillis re:`Shape` instantiation - absolutely agree, see above comment: > The way to do it with the declarative approach would be that Shape actually accepts Omit rather than a ShapeStream...

Move `stream.subscribe()` to be part of the constructor

@KyleAMathews I like the idea of the stream being "pull based" - and if you want multiple subscribers, you can first setup a subscriber to forward messages to e.g. 3...

Move `stream.subscribe()` to be part of the constructor

Bumping this issue to move it along - how are we feeling about `ShapeStream` needing extra stream processing? If we make the change such that `ShapeStream` only starts streaming when...

Move `stream.subscribe()` to be part of the constructor

@samwillis re:microtasks - indeed this is the only reason that our test suite and most use cases are _mostly_ working, my issue is that this behaviour will undoubtedly lead to...

Remove snapshots and unify them with shape log instead

Worth mentioning that we also need to decide on the addressability of the snapshot entries - currently all of the snapshot is being served ending at offset `0_0` - I...

Add a packageManager property to root `package.json` to enable use of corepack

We include a [`.tool-versions`](https://asdf-vm.com/manage/configuration.html#tool-versions) configuration file for the [asdf runtime manager](https://asdf-vm.com/) which includes the `pnpm` version used for the workspace. This allows us to specify the package manager, node version,...