Michael Froh

@naomichi-y -- are you still working on this PR? @OVI3D0 -- are you able to help get it across the line? You can clone from https://github.com/naomichi-y/OpenSearch/tree/feature/fix-parseToken-array-popping and try to do...

@naomichi-y , @OVI3D0 -- I hope you don't mind, but I pushed a refactoring commit for `parseToken` that (in my opinion) is a lot easier to understand. @reta -- I...

The build failures seem to be related to this. I'll try running the yamlRestTest target to see what's breaking.

Oof... that was complicated. Even debugging the yamlRestTests, the cause of failure wasn't obvious. It turns out that it was all because I was stepping past the final `END_OBJECT` token,...

``` java.lang.AssertionError at __randomizedtesting.SeedInfo.seed([D25DBB2E808359FD:17E94777B0CD7A53]:0) at org.opensearch.common.xcontent.JsonToStringXContentParser.parseObject(JsonToStringXContentParser.java:69) at org.opensearch.index.mapper.FlatObjectFieldMapper.parseCreateField(FlatObjectFieldMapper.java:582) at org.opensearch.index.mapper.FieldMapper.parse(FieldMapper.java:269) at org.opensearch.index.mapper.DocumentParser.parseObjectOrField(DocumentParser.java:527) at org.opensearch.index.mapper.DocumentParser.parseNullValue(DocumentParser.java:725) at org.opensearch.index.mapper.DocumentParser.innerParseObject(DocumentParser.java:451) at org.opensearch.index.mapper.DocumentParser.parseObjectOrNested(DocumentParser.java:419) at org.opensearch.index.mapper.DocumentParser.internalParseDocument(DocumentParser.java:138) at org.opensearch.index.mapper.DocumentParser.parseDocument(DocumentParser.java:93) at org.opensearch.index.mapper.DocumentMapper.parse(DocumentMapper.java:251) ``` Hmm... apparently I missed the...

> This way, we can separate the addition to build.gradle and a repository-wide application of spotlessApply. I'm not sure that really helps, and would just leave us temporarily broken. IMO,...

@kulket, @mishprs -- can one of you take this one? Just comment on this issue and we can assign it to one of you. (We can't assign it until you...

@sejli -- Are you able to take this one?

@reta pointed out that there are non-query factors (like search pipelines, especially if they call out to an external service) that can impact the search results, such that the same...

I see that nobody seems to argue against doing this -- it's been idle for 2 years, though. Could we just move the code from this repo to OpenSearch core's...