Marcello Seri comments

Results 435 comments of


                                            Marcello Seri

stats_rv test failure with Clang

I am happy to make all the hard coded flags that can cause problem configurable via custom flags, with the dune 2 changes it will be much easier to do...

stats_rv test failure with Clang

Thanks. I hope we can also figure out the reason of that failure and close this issue as well

stats_rv test failure with Clang

I wonder if the error on such small margin is meaningful, would it make sense to update the bound to `E-27` or `5E-28`?

fancy slicing does not seem to work with extended indexing operator

They are defined in the owl_operator.ml file, have a look at this PR: https://github.com/owlbarn/owl/pull/543

fancy slicing does not seem to work with extended indexing operator

In particular, I think you would need to add it to the `Make_Ndarray` functor

fancy slicing does not seem to work with extended indexing operator

I think it would be convenient to have them. I cannot speak for everybody but I would be favourable to a PR introducing them, especially since there is a discrepancy...

Test failure in AD

Should we close this or we want to keep it open to think about an improvement for the tests?

Improve type safety of operations

Yes, I agree. I created this issue as an opportunity for brainstorming and for evaluating/comparing examples. Thanks for pointing out the other issue

Improve type safety of operations

> In any cases, I would not be in favor of changing owl's api but rather, as @ryanrhymes proposed in #374, to propose a tiny library exposing the same operations...

Undefined behavior when adding an empty 1-ary array to a zeroary array

Thanks for reporting it. This requires touching `owl_ndarray_maths_stubs` and `owl_utils_infer_shape`, which I am not familiar with. @ryanrhymes or @tachukao could you look into this?