mselim00
mselim00
Absorbed into https://github.com/awslabs/amazon-eks-ami/pull/2446 The VPC CNI has yet to implement support for allocating on multiple ENIs, and even when it does, the fallback should line up with the default values...
> Do we have to vendor the CNI repository here? Can't we add as a go.mod dependency ? We vendor all dependencies for nodeadm to allow for consistent and network-less...
Working on splitting off the limiting aspect for the max pods value in another PR: https://github.com/awslabs/amazon-eks-ami/pull/2325
Superseded by #2446
Had to update the build image for go 1.25 /ci
the `1.25` image in `public.ecr.aws/eks-distro-build-tooling/golang` is pointing to `1.25.0` but we need go `1.25.1`, checking if that'll be updated soon or if we should start setting the full version
/ci +build nodeadm_build_image=public.ecr.aws/eks-distro-build-tooling/golang:1.25.1
just want to validate the build works by default now since a new 1.25 golang image was released /ci build +workflow:k8s_versions 1.33