healthkit-sample-generator icon indicating copy to clipboard operation
healthkit-sample-generator copied to clipboard

update to Swift 5, add new HealthKit parameters

Open mkhoshpour opened this issue 5 years ago • 7 comments

Hi, please review my PR I have updated code for swift 5.0 and added new HK parameters. The repo is compatible with Xcode 11 now.

Thanks

mkhoshpour avatar Oct 14 '19 15:10 mkhoshpour

Anyway to get the compatible code with swift 5?

Lukas182 avatar Nov 21 '19 10:11 Lukas182

Anyway to get the compatible code with swift 5?

check my fork please: https://github.com/mkhoshpour/healthkit-sample-generator/tree/master

mkhoshpour avatar Nov 21 '19 11:11 mkhoshpour

awesome! Ill check it right now :D

Lukas182 avatar Nov 21 '19 11:11 Lukas182

giving me error finding a info.plist :(

/healthkit-sample-generator-master/Example/Pods/Target Support Files/HealthKitSampleGenerator/ResourceBundle-HealthKitSampleGenerator-HealthKitSampleGenerator-Info.plist

Lukas182 avatar Nov 21 '19 11:11 Lukas182

@Lukas182 fixed, please check again

mkhoshpour avatar Nov 21 '19 12:11 mkhoshpour

Thanks! @mkhoshpour :D!

Lukas182 avatar Nov 21 '19 12:11 Lukas182

Hello mate, could you merge to master? once approved thanks @mkhoshpour

mednoor avatar Dec 11 '19 20:12 mednoor