Mark Schofield
Mark Schofield
My team ship an SDK, and would like to encapsulate the implementation details as much as possible. In the past we've taken on Java-side dependencies (specifically an HTTP client stack...
To get anything app-related, then `LogManager` would need the Android `Context` for the application. At the minute, the `Context` doesn't _appear_ to be passed in (I could be missing it;...
Correct. I was able to get _further_ by setting `CFG_STR_CACHE_FILE_PATH` to a fully qualified path to a writable folder (and, yes, I used the Context to call [Context.getCacheDir()](https://developer.android.com/reference/android/content/Context#getCacheDir()) from native...
I didn't try not specifying the PRAGMA - [the SQLite documentation for temporary files](https://sqlite.org/tempfiles.html) calls out the paths it tries, and I was skeptical that they would work on Android,...
> I don't think it's a complete fix, since we had to scrap a couple earlier attempts (https://github.com/microsoft/WindowsAppSDK/pull/5685, https://github.com/microsoft/WindowsAppSDK/pull/5782). Thanks for linking to the earlier attempts. TBH, both of those...
Sorry, I don't understand your [suggestion](https://github.com/microsoft/WindowsAppSDK/pull/5685#issuecomment-3229606953). How would you add the PreprocessorDefines? You'd still need to utter `%(PreprocessorDefines)` in an ItemGroup in a Target, wouldn't you? At the minute, the...
> Having different definitions of PreprocessorDefines is what causes the batching. Indeed, and I don't think we can prevent different definitions of PreprocessorDefines, because customers can easily write valid vcxproj...
I've updated this PR with an implementation that takes the ItemDefinitionGroup-approach. This is - IMHO - a tidier approach. The only downside is that if customers are setting any of...
I've addressed Christopher's comments - thanks! - and pushed a final version. TBH, I hadn't realized that the same pattern is used in multiple places across the build infrastructure -...
> > @mschofie Is this ready to complete? Have we confirmed it won't regress WinUI builds? > > After adding `NotUsing`, I successfully built the Foundation package and tested it...