Matthias Schoettle comments

Results 183 comments of


                                            Matthias Schoettle

chore(core): remove upper limit for angular dependency

@mportuga Please review

chore(core): remove upper limit for angular dependency

@mportuga Thanks! What is the timeline for a new release that will include this fix (is there a plan)?

Page number incorrect when using TableOfContents.render_toc

Thanks! I added this to all MREs and updated the issues. MRE3 works with using roman numerals for the ToC and then arabic numerals for the content. The only problem...

Page number incorrect when using TableOfContents.render_toc

Thanks for your response @Lucas-C and the partial fix! > when the ToC spans more than one page, .footer() is called for every page with an incorrect value returned from...

Ignore first element if it is a comment when determining page title

> I can assure you that this `break` was not accidentally mis-indented. Accepting a heading only at the very beginning folows the same idea as the [original behavior since the...

Ignore first element if it is a comment when determining page title

I reverted my change and added a more targeted change to skip the first element if it is an HTML placeholder.

Add check to match FromAsCasing Docker build check

This would be great to have! > Side note: I haven't checked myself, but there might more build checks that might be suitable candidates to have corresponding checks here? Another...

Problems with the new type annotations

> I totally agree at runtime, but when doing static type checking, mypy find this error: > > `error: Call to untyped function "SubFactory" in typed context [no-untyped-call]` > >...

Fix handling of IP when setting DJANGO_EASY_AUDIT_REMOTE_ADDR_HEADER to HTTP_X_FORWARDED_FOR

I've noticed this too. When running app and reverse proxy in a container you get the container IP. There is also the `HTTP_X_REAL_IP` header. Would that work? In your case...

Fix handling of IP when setting DJANGO_EASY_AUDIT_REMOTE_ADDR_HEADER to HTTP_X_FORWARDED_FOR

Good to know. It could look at all of them in the following order of preference: `HTTP_X_REAL_IP`, `HTTP_X_FORWARDED_FOR`, `REMOTE_ADDR`. Could you show an example of how the `HTTP_X_FORWARDED_FOR` header looks...