log4perl icon indicating copy to clipboard operation
log4perl copied to clipboard

Log::Log4perl::Appender::File is using two args open

Open atoomic opened this issue 3 years ago • 2 comments

We should consider enforcing three args open in Log4perl

this is coming from sub file_open Log::Log4perl::Appender::File

     eval {
         if($self->{syswrite}) {
             sysopen $fh, "$self->{filename}", $sysmode or
                 die "Can't sysopen $self->{filename} ($!)";
         } else {
             open $fh, "$arrows$self->{filename}" or
                 die "Can't open $self->{filename} ($!)";
         }
     };

atoomic avatar Feb 02 '22 21:02 atoomic

Pull requests welcome!

mohawk2 avatar Jun 01 '22 23:06 mohawk2

@mohawk2 just sent a PR with these changes

atoomic avatar Nov 17 '22 23:11 atoomic