Moritz Schauer

Results 302 comments of Moritz Schauer
trafficstars

This does the trick, needs some test etc. ``` function Base.iterate(p::IntegerPartitions, xs = Int[]) length(xs) >= p.n + (p.n == 0) && return nothing xs = nextpartition(p.n,xs) (xs, xs) end...

What do we do with this? Can we make this non-breaking?

I would opt for deprecate it and keep it doing what it did before instead of collecting `partitions(n::Int)`

Looks like it checks for "having a neighbour" https://github.com/JuliaMath/Combinatorics.jl/blob/master/src/youngdiagrams.jl#L78 instead of connectedness, as in you example every cell has a neighbour but the diagram is not connected.

Can you check if there is something in `https://github.com/JuliaMath/Combinatorics.jl/blob/master/src/youngdiagrams.jl` which is not covered by your code? If would almost propose to remove it here and refer to `https://github.com/Nemocas/AbstractAlgebra.jl` for the...

Otherwise if you wrote the code in question, than you allow the use of the code under MIT for this package by saying so.

Agreed. But if you want you can add a reference to PDMATs in the docs, just similar to this one: https://juliastats.org/Distributions.jl/latest/multivariate/#Distributions.AbstractMvNormal

Connected to #1483, there is a latent need for being able to dispatch on distributions which have merely uncountable support and those which are absolute continuous.

Exactly, but we would like to exclude the general case from the standard definitions.