Moritz Schauer
Moritz Schauer
I think it's fine to use `Base.require_one_based_indexing` then, see also https://docs.julialang.org/en/v1/devdocs/offset-arrays/ . We could even add a docstring for `Base` in a slow moment.
Can you make a second, new issue where you describe the problems you encounter with `closed`? Thank you
Could be actually a good moment to look at this, as https://github.com/JuliaStats/StatsBase.jl/pull/605 is fixed now.
1.) mutability is used to keep the sum updated
@ararslan You needed this?
> Yes? Nothing, I just remembered that you were looking for something like this is think, so I thought I point it out.
Often it is also helpful if you go on record and state if *you* think yourself that this is ready to be merged and let loose on the world.
I am going through stalled pull requests of this repo. If you have time and interest to update this, I'm going to review and merge.
Do you have an idea for the fix?
Could just be #52