Matthew Scharley

Results 36 comments of Matthew Scharley

Oh, hey thanks for the shout out! There's still some pretty big gaps in the documentation in places, especially getting started but if you're already familiar with Inversify it shouldn't...

Have a look over here: https://github.com/typeorm/typeorm/issues/171#issuecomment-347724850

> I'm not using testdouble. You easily could be, though. We use both `testdouble` and `sinon`, they're both good at different things. `testdouble` is very good for this particular problem....

For unit tests, using the approach I mentioned in the other thread *you don't need anything from typeorm*, it just works. That's why I suggested it. With minimal code in...

I'll just repeat my previous comments with a little extra justifications and leave it at that. TL;DR version: typeorm doesn't need anything new implemented, in my opinion. There's two cases...

@rarkins This has the help wanted tag but hasn't been updated in a few months. Is there anything outstanding that needs help specifically? ie, how can we help move this...

What would that look like? For reference, this is about one of the simplest possible rush repos out there: https://github.com/mscharley/node-presets 1. Detect rush repository based on `rush.json` in the top...

So, the `change` command adds these files into the repo: https://github.com/mscharley/node-presets/pull/9/commits/96c709219b10be2514ecc831f16ed03cfa0cc258 Other than adding cruft to a repo that doesn't use them, I don't believe they're actively harmful. A configuration...

Wait, I take that back after re-reading the config option, `bumpVersion` does sound appropriate for the `change` command and has the right options too, though an explicit `"none"` might be...

> Add an updateArtifacts() function which runs install-run-rush.js update. I think we'd want to make sure it runs once for the entire rush project and not once per-package.json, although would...