ssh2-streams icon indicating copy to clipboard operation
ssh2-streams copied to clipboard

Fix bigIntToBuffer for numbers that start 0x9

Open Timmmm opened this issue 4 years ago • 6 comments

Numbers that start 0x9... did not have '00' prepended.

Fixes #163

Probably a good idea to add a unit test for this function! I don't have time at the moment though, sorry.

Timmmm avatar Aug 20 '20 10:08 Timmmm

What's going on with this? How come it's not yet accepted?

dylanh724 avatar Oct 16 '20 12:10 dylanh724

@dylanh724 ssh2 is undergoing a rewrite that no longer depends on this project, so all effort is now being spent there.

mscdex avatar Oct 16 '20 12:10 mscdex

cheers

dylanh724 avatar Oct 16 '20 13:10 dylanh724

Please can you merge this in the mean time - looking forward to the rewrite but presumably that is some way off?

If you don't want the hassle I am willing to maintain this repo until your rewrite is ready.

Timmmm avatar Oct 16 '20 14:10 Timmmm

Please can you merge this in the mean time - looking forward to the rewrite but presumably that is some way off?

If you don't want the hassle I am willing to maintain this repo until your rewrite is ready.

This would rock. This is a breaking bug for all those that use it, both directly and indirectly. I'm actually surprised it wasn't already since it's a 1-liner.

dylanh724 avatar Oct 22 '20 04:10 dylanh724

Also having issue with this

allinws avatar Oct 07 '21 08:10 allinws