socksv5 icon indicating copy to clipboard operation
socksv5 copied to clipboard

copy normalizeConnectArgs from node 6

Open lee-elenbaas opened this issue 9 years ago • 6 comments

This should fix #22

lee-elenbaas avatar Oct 27 '16 09:10 lee-elenbaas

net._normalizeConnectArgs is not longer available on node 7 - so i removed the dependency in it, by placing the implementation inside the library

lee-elenbaas avatar Oct 30 '16 09:10 lee-elenbaas

@mscdex do you have time to review this PR? This is likely true as we have a few users reporting similar issues.

bitinn avatar Jan 07 '17 14:01 bitinn

👍 , I am also having this issue.

malexdev avatar Mar 08 '17 16:03 malexdev

Same here - breaks on node >7. The fix looks good!

cjnqt avatar Aug 01 '17 23:08 cjnqt

@cjnqt since @mscdex does not seem to be active - feel free to use my fork

lee-elenbaas avatar Aug 02 '17 12:08 lee-elenbaas

Ping @mscdex - could you please merge this?

cjnqt avatar Nov 15 '17 07:11 cjnqt