node-mariasql
node-mariasql copied to clipboard
asserts enabled in binding.cc
I was doing some resiliency testing on HEAD and noticed that binding.cc was asserting, when the db was restarted (I was testing). Two things:
- It seems asserts are by default enabled... should you disable those? ... add #define NDEBUG to binding.cc?
- that assert seems to be firing under an expected condition (the db going away for a moment) but that's a bit over my head, just wondering.
node: ../src/binding.cc:992: static void Client::cb_poll(uv_poll_t*, int, int): Assertion `status == 0' failed.
to disable asserts, I modified binding.gyp 'cflags': [ '-O3', '-std=c++0x', '-DNDEBUG' ],
this resolved my issue of asserts causing my program to crash (when the db went away)
Happens to me as well.. a lot