node-mariasql icon indicating copy to clipboard operation
node-mariasql copied to clipboard

asserts enabled in binding.cc

Open bneutra opened this issue 7 years ago • 2 comments

I was doing some resiliency testing on HEAD and noticed that binding.cc was asserting, when the db was restarted (I was testing). Two things:

  1. It seems asserts are by default enabled... should you disable those? ... add #define NDEBUG to binding.cc?
  2. that assert seems to be firing under an expected condition (the db going away for a moment) but that's a bit over my head, just wondering.

node: ../src/binding.cc:992: static void Client::cb_poll(uv_poll_t*, int, int): Assertion `status == 0' failed.

bneutra avatar Mar 10 '17 23:03 bneutra

to disable asserts, I modified binding.gyp 'cflags': [ '-O3', '-std=c++0x', '-DNDEBUG' ],

this resolved my issue of asserts causing my program to crash (when the db went away)

bneutra avatar Mar 14 '17 00:03 bneutra

Happens to me as well.. a lot

Eli-Goldberg avatar Jan 07 '18 04:01 Eli-Goldberg