node-mariasql icon indicating copy to clipboard operation
node-mariasql copied to clipboard

default charset: latin-1?

Open bneutra opened this issue 7 years ago • 1 comments

I'm finally upgrading from 0.1.21 (!) to 0.2.6. It appears to me that the default charset (when creating New Client) changed (from utf-8 to, not sure, latin-1?) I noticed in the 0.1.22 README.md it says the default charset is utf-8, then later the documentation doesn't specify what the default is.

Honestly, I'm good (I just added charset: 'utf-8' to the connection options) But I ended not being able to figure out how it every worked for me on 0.1.21 (i.e. how the charset option propagates through the code to the c code). And I thought I'd just let you know and encourage you to document the default behavior in the README.md, so other's don't get burned by assuming stuff.

bneutra avatar Mar 07 '17 22:03 bneutra

it looks like you are right. I am fixed it with "charset: 'utf 8'" in the constructor config.

antishov avatar Mar 08 '17 20:03 antishov