node-ftp icon indicating copy to clipboard operation
node-ftp copied to clipboard

Published 20 hours ago • verified publisher icon mscdex

REST send before RETR if restart is used. fixes #76

Open holymoly opened this issue 10 years ago • 4 comments

this commit fixes #76

holymoly avatar Jan 22 '14 22:01 holymoly

Don't know why this happend. thought that naming the issue should be enough...

holymoly avatar Jan 22 '14 22:01 holymoly

This ones fixes the issue with the restart command. Would be good if someone check the code.

holymoly avatar Feb 03 '14 10:02 holymoly

Aside from the inline comments, there are a couple of other issues:

  • The err argument passed to the callback in _send() should be checked (in case REST is not supported on the server) and appropriate action should be taken if err is indeed set.
  • Code style should match the rest of the source code (mainly spacing here)

mscdex avatar May 21 '14 19:05 mscdex

I hope to find some time to change the other things (check Rest support of Server, err Handling and Code Style) on the Weekend.

holymoly avatar May 22 '14 07:05 holymoly