mmmagic icon indicating copy to clipboard operation
mmmagic copied to clipboard

Please upgrade file version (e.g. better docx detection)

Open antoinep92 opened this issue 3 years ago • 2 comments

We had a bug where a file upload was rejected by our backend, and tracked it down to mmmagic classifying a docx file uploaded by a user as application/octet-stream, while my system's file command correctly detects it.

There are two things here:

  • If I use the MAGIC_CONTINUE flag, it returns [ '', 'application/zip', 'application/octet-stream; charset=binary' ], so when not using this flag one could expect application/zip, but we get application/octet-stream which is both less specific and appears later in the list, so it seems a bit strange to me. Don't know if it's the upstream file behaviour or if there's something wrong with the js code here.
  • It would be great if you could upgrade the file version distributed here. Currently it's 5.32 and I have 5.40 installed on my system. Apparently the docx detection got better, and I guess a bunch of other improvements too. I don't know if the build changes much between releases, but hopefully it's just a version bump ?

It so happens that the file is publicly available, which allows me to share it : https://www.hetsl.ch/cv/romain-bertrand/cv.docx

antoinep92 avatar Aug 02 '21 18:08 antoinep92

hi @antoinep92 how did you work around this issue, if at all?

ssinghi avatar Aug 07 '24 07:08 ssinghi

I don't remember for this specific issue, but we switched to wasmagic, you could try it and see if it works better for you

antoinep92 avatar Aug 08 '24 08:08 antoinep92