dicer icon indicating copy to clipboard operation
dicer copied to clipboard

Crash in HeaderParser in dicer - git hub security alert

Open pravichandran15 opened this issue 2 years ago • 12 comments

Please find the link below for the git hub security alert.

https://github.com/advisories/GHSA-wm7h-9275-46v2

pravichandran15 avatar May 26 '22 14:05 pravichandran15

It seems it will be not fixed in dicer: https://github.com/mscdex/dicer/pull/22 If like me the vulnerability come from multer, a fix is on going: https://github.com/expressjs/multer/pull/1097

jitbasemartin avatar May 26 '22 15:05 jitbasemartin

In our case the vulnerability is coming from firebase-admin. Is there any fix available?

deepaljain avatar May 30 '22 04:05 deepaljain

Need fix for this so Nestjs can be patched. Is there an eta?

kbocock-krg avatar Jun 02 '22 16:06 kbocock-krg

This PR should fix NestJS: https://github.com/nestjs/nest/pull/9686

jitbasemartin avatar Jun 02 '22 16:06 jitbasemartin

Duplicate of my post on the same issue, elsewhere:

Preamble: I am a novice and this is not advice on what you should do - I'm just relaying what I did and what the outcome was.

After deploying my Vuejs3 app a week ago to Firebase, I was prompted to upgrade to the newest version of Firebase Tools (11.0.1) via npm. After doing this, I began experiencing the problem detailed in my comment above.

Having no other solutions on the table, I decided to uninstall firebase tools (npm uninstall -g firebase-tools) and then reinstall the previous version (npm install -g [email protected]).

BUT, after first time I did this, I ran npm audit fix (not npm audit fix --force) and all I got a ton of high severity warnings and problems.

So I decided to once again uninstall firebase tools (npm uninstall -g firebase-tools) and then reinstall the previous version (npm install -g [email protected]) and that's it (did NOT run npm audit fix).

I proceeded to npm run build and firebase deploy --only hosting and it worked just fine. Definitely NOT a great or long-term solution. Good luck!

mgav avatar Jun 03 '22 14:06 mgav

In our case the vulnerability is coming from firebase-admin. Is there any fix available?

Me too

Lucas-Angelo avatar Jun 03 '22 20:06 Lucas-Angelo

Solution that worked for me was to add: (In our case it's nest)

"overrides": {
    "@nestjs/platform-express": {
      "multer": "1.4.4-lts.1"
    }
  },

to package.json. Though, it comes with a requirement of a minimum of npm 8.3.0. So we added that to the package.json as well. Also, please do delete package-lock.json and node_modules beforehand.

More on overrides

pavleprica avatar Jun 06 '22 11:06 pavleprica

I have a dep chain apollo-server-express > apollo-server-core > @apollographql/graphql-upload-8-fork > busboy > dicer throwing this High severity vulnerability for dicer 0.3.0 (fixed dependency version in busboy 0.3.1, unfortunately). Is there an estimated date for fixing this?

lorand-horvath avatar Jun 08 '22 10:06 lorand-horvath

I have dep chain that throws this: "graphql-upload": "11.0.0" --> busboy "^0.3.1" --> dicer "0.3.0"

Any update on this?

RikuRuokonen avatar Jun 20 '22 12:06 RikuRuokonen

@RikuRuokonen Lodge an issue with the graphql-upload project owners to update their busboy dependency.

mscdex avatar Jun 20 '22 12:06 mscdex

@mscdex Well, I have raised an issue with apollo-server asking them to fix the busboy 0.3.1 dep vulnerability in Apollo Server 2.x https://github.com/apollographql/apollo-server/issues/6590 The reply was to update to 3.x Please upgrade to AS3. AS4 is close to ready! AS2 ships with hardcoded integrations with many pieces of outdated and unmaintained software. which I cannot personally do because it's in fact a dependency of @vue/cli - I posted an issue there as well and haven't got any response yet https://github.com/vuejs/vue-cli/issues/7198 So I'm running in circles, I guess...

@RikuRuokonen You cannot open an issue with graphql-upload in this repo https://github.com/apollographql/graphql-upload because the function is disabled. Unless we are talking about the original repo https://github.com/jaydenseric/graphql-upload

lorand-horvath avatar Jun 20 '22 14:06 lorand-horvath

Solution that worked for me was to add: (In our case it's nest)

"overrides": {
    "@nestjs/platform-express": {
      "multer": "1.4.4-lts.1"
    }
  },

to package.json. Though, it comes with a requirement of a minimum of npm 8.3.0. So we added that to the package.json as well. Also, please do delete package-lock.json and node_modules beforehand.

More on overrides

It works for me too, thanks!

gerson-ribeiro avatar Jul 27 '22 12:07 gerson-ribeiro