mscdex
mscdex
Also what should happen when neither a string nor array is passed in? Is a 103 without headers permitted? Should we throw an exception? Either way we should also add...
minor nit: perhaps we could consolidate the tests into one file for this new feature? Additionally we should test that the function throws when it should.
> I think there will generally be more specialized solutions that people can use if whatever node ships doesn't fit their specific need. This feature request seems like one of...
> We for example ship `acorn` which is not used outside of the REPL. We also have websockets implementation for the inspector but never expose it either. We don't already...
I am still -1 on this.
@devsnek for the same reasons I gave in the linked issue.
@MylesBorins I don't think node should aim to become a (DOM-less) browser. Anyway, my "vote" and reasoning still stands.
Has anyone ran any of the benchmark comparison before and after this PR? I'd be interested in seeing the performance difference. I would try it myself but it seems there...
I don't know offhand, but I think just seeing results in libuv's benchmarks in test/ would be enough.
So does everyone agree that the bot should (at least) not add any backport-related labels if it sees a change in commits and a `semver-major` is set on the PR?...