mscdex
mscdex
> So you wanted to do a ssh-keygen from within the sftp server and share the privateKey part of it? Doesn't matter where it's generated, as long as it reproduces...
I don't understand how using a `v8::Eternal` fixes a thread safety issue. AFAIK the only real difference between `v8::Eternal` and `v8::Persistent` is the lifetime of the value. `v8::Eternal` will always...
Is the underlying reason for the worker-related issues that `constructor()` returns a static `v8::Persistent`?
@rmnilin Can you include a test in this PR? Other than that, I am fine with these changes I guess.
@rmnilin It looks like the new test will need to be skipped for older node versions. I think the best way to do that is to wrap the `require('worker_threads')` in...
Thanks, landed in dd5510c0888476e9eec205273732473fcce5adc6.
Yep, modern versions of OpenSSL do a lot of extra checks on DH values in the name of security. You're better off using Curve25519 instead where possible, which AFAIU does...
> is there a way reduce the amount of checks so its faster? Short of patching OpenSSL and/or node, there is no way to reduce the amount of checking. >...
Additionally you could try newer versions of node and/or OpenSSL (if your copy of node is using system OpenSSL), it's possible improvements in OpenSSL could make things faster somehow.
> I seems that it might be better to add an additional parameter to the sftp() method, i.e. in `client.js` it would appear as `sftp(env, cb)` That would be the...