SteveJobs
SteveJobs copied to clipboard
msavin
Async migration
In progress... Gonna wrap things up in a couple of days :crossed_fingers: I'm trying now to get the tests to pass flawlessly.
Hey looks great so far! Thanks for the effort.
Are you planning to fork or looking to merge?
To merge of course! It's just I've not heard from you ever since I started this PR and I wanted to take it for a test run. Please review and if it's all good let's do a beta release and see how it goes from there. I'll rename it back after we conduct code review then do the beta.
@harryadel Sweet I'll test this out soon - is it all ready or is there more to do?
@msavin AFAIK, this is ready. At our application we only use it twice to run very simple jobs. That's why there might be a few bugs lingering here or there so I need others to give it a test run.
First to say thank you all for all the effort in migrating this amazing package! I just wonder if there's any progress with testing and merging, would really like to see it available for Meteor 3!
hi @harryadel, I've been using your fork in a Meteor 3.0 project and I have some warnings in server console :
TypeError: Promise.await is not a function at process (packages/harry97:sjobs/server/imports/actions/execute/process.js:15:29) at execute (packages/harry97:sjobs/server/imports/actions/execute/index.js:12:25) at processTicksAndRejections (node:internal/process/task_queues:95:5)
Is this misconfiguration on my side ?
(to be specific, I use @StorytellerCZ version ! so I'm also tagging him here ;) ! https://github.com/StorytellerCZ/SteveJobs/commit/96ad8642e81b6c32d7bf0fbd837f2ae49fc77d4a)
hi @harryadel, I've been using your fork in a Meteor 3.0 project and I have some warnings in server console :
TypeError: Promise.await is not a function at process (packages/harry97:sjobs/server/imports/actions/execute/process.js:15:29) at execute (packages/harry97:sjobs/server/imports/actions/execute/index.js:12:25) at processTicksAndRejections (node:internal/process/task_queues:95:5)
Is this misconfiguration on my side ?
(to be specific, I use @StorytellerCZ version ! so I'm also tagging him here ;) ! StorytellerCZ@96ad864)
Did you checkout feature/async branch? I just tried to use it as a local package – cloned StorytellerCZ version, checked out feature/async branch, copied to myproject/packages directory, installed with meteor add msavin:sjobs and tried to schedule a simple job. No errors so far. :)
My bad ! I did indeed cloned Storyteller version but I had harry97:sjobs in my package file 🤦
Seems to work like a charm now !
OK, I'll get on Harry to merge my changes so that we can then merge this here.
@vparpoil @StorytellerCZ I just merged in your contributions guys, thank you for your amazing efforts. I've been busy the last week and couldn't free up time to OSS.
@msavin I think we can publish a beta or rc with this. I'm using this in production without issues.