Michelle Au

Results 302 comments of Michelle Au

We can do a similar thing with the volume-id and have a method where plugins can define their own valid/invalid syntaxes. /kind bug /help

Have we implemented all of these test cases? /lifecycle frozen /help

Yes, basically anytime we have to list, like [here](https://github.com/kubernetes-csi/external-provisioner/blob/0c56ab07a68cbe7b186d96f2afa8e00b5895066b/pkg/controller/topology.go#L321) also. The performance benefit should theoretically show up when: 1) you have a lot of nodes and 2) you have very...

/lifecycle frozen

Do you see a problem if we mark VolumeAttachment as detached while it's still attaching? How is this different from the normal case when we are first attaching a volume...

When a node is deleted, the combination of pods getting deleted and AD.verifyvolumesattached causes the detach

I forgot to mention in the initial comment, the Pod does get deleted, which should trigger detach, however AD controller doesn't because it still sees the volume mounted in asw...