atom-elixir icon indicating copy to clipboard operation
atom-elixir copied to clipboard

Port to JavaScript (ES6)

Open jayjun opened this issue 8 years ago • 3 comments

There appears to be an unofficial move to JavaScript, especially for new development. I think it’s a good move, for aspiring contributors and future-proofing.

In this pull request, I refactored (by hand) all CoffeeScript to JavaScript, and CSON to JSON.

Since the tests were not working to begin with, I can’t say for certain that nothing broke. However, I have used it in my daily work and it’s been 100% the same.

Personally, I never want to learn CoffeeScript well. So, this is really my first step to future contributions!

jayjun avatar Jul 02 '17 14:07 jayjun

@jayjun this is fantastic! Getting rid of CoffeeScript is definitely wanted. I'll start using your branch right away so I can use/test it for a couple of days and then I'll merge it.

Thanks for your contribution!

msaraiva avatar Jul 14 '17 02:07 msaraiva

@msaraiva Cool, my fork was deleted. Anyway, it’s all back up on GitHub. Let me know if you need a new pull request.

jayjun avatar Jul 14 '17 05:07 jayjun

If you merge this I'd love to help out, but I'm just dreadful at CoffeeScript!

NuckChorris avatar Feb 25 '18 20:02 NuckChorris