Michael Santos comments

Results 82 comments of


                                            Michael Santos

Getting ip address of guest vm

Thanks! I caught that as well and fixed it after I published the comment. The rule is that the 2nd element in both tuples (argument and return) can be thought...

Add PAM_RUSER format specificier

specificier -> specifier

authorized_keys_command= is passing wrong username argument when used in /etc/pam.d/su-l

FYI there is a patch to set PAM_RUSER to work with programs like su(1): https://github.com/jbeverly/pam_ssh_agent_auth/pull/7

Failure to decode ethernet frame with trailing pad (Invalid decoding of Fin-Ack to contain payload)

That makes sense. So I guess it is up to the user to calculate the length and truncate the frame. I can add a section about ethernet frames to the...

Failure to decode ethernet frame with trailing pad (Invalid decoding of Fin-Ack to contain payload)

About the variable name, agreed, I will try to make that clearer. Updating sniff is a good idea too. IPv6 packets are so large, I wonder if this will be...

Failure to decode ethernet frame with trailing pad (Invalid decoding of Fin-Ack to contain payload)

Added to README.

Failure to decode ethernet frame with trailing pad (Invalid decoding of Fin-Ack to contain payload)

I've been thinking pkt should follow the C headers, i.e., parse fixed length packet headers into a record and provide a function to parse variable length headers/payload. For example, this...

Failure to decode ethernet frame with trailing pad (Invalid decoding of Fin-Ack to contain payload)

I agree with what you are saying (the erlang representation should match the packet) but the pad in this case is a convenience when specifying TCP options. If you want...

Failure to decode ethernet frame with trailing pad (Invalid decoding of Fin-Ack to contain payload)

BTW, thought about this and I agree the pad should be in the record structure. To preserve the default behaviour (calculating the correct pad), the pad will be calculated if...

Failure to decode ethernet frame with trailing pad (Invalid decoding of Fin-Ack to contain payload)

Looks like I still need to make this change. Basically add a pad field to the tcp record and use if set. Otherwise, calculate the padding required.