Mikael Sand

Results 142 comments of Mikael Sand

Its in my fork here: https://github.com/msand/react-native-svg/tree/filters?files=1 You can just modify the code while it's in node_modules and rebuild the native side. Alternatively you can use npm link.

@glthomas Great! It might make sense to rebase onto master of the main repo as well. Actually, fork this repo and make a PR here instead. I only use that...

@glthomas Sounds good. I rebased onto master here and pushed to the filters-branch, lets use this one going forwards. Please feel free to ask anything if there's something I might...

@glthomas Excellent, seem you're on the right track. It would probably make sense to refactor the masking logic a bit. First extract a method to render a node to a...

For the feMergeNodes, we should have the parseReference method of the RNSVGFilter to set up a filter graph (map from index/name to filter instance, and the outputs of instances are...

Ah, as long as it's defined by the spec, and some ever-green browser supports it, then ideally react-native-svg would support it as well. There's a workaround here: https://github.com/react-native-community/react-native-svg/pull/920 But should...

You don't trust the commit log to tell you this?

It not exactly faking it, more like actually calculating it 😉 It might be possible to do using OpenGL, or RenderScript, it might be more performant for some use cases,...

Can you post a full reproduction?

I mean the content of the svg file