Zhenhua Hu

Results 31 comments of Zhenhua Hu

Since `azapi` uses `Azure Go SDK` to complete token authentication which is different from `azurerm`, we need `Azure Go SDK` to expose an interface to us to make `msi` selectable....

> }, LRO-Delete does not need 200 --- Refers to: specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json:200 in 2f24e4f. [](commit_id = 2f24e4fd0275eb41cc31384478a4ed569a7a0b50, deletion_comment = False)

> "201": { resolved with [https://msazure.visualstudio.com/AzureContainerRegistry/_workitems/edit/24778096](https://msazure.visualstudio.com/AzureContainerRegistry/_workitems/edit/24778096)# --- In reply to: [1666239876](https://github.com/Azure/azure-rest-api-specs/pull/24771#issuecomment-1666239876) [](http://example.com/codeflow?ancestors=1666239876) --- Refers to: specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json:268 in 2f24e4f. [](commit_id = 2f24e4fd0275eb41cc31384478a4ed569a7a0b50, deletion_comment = False)

> "201": { resolved with [https://msazure.visualstudio.com/AzureContainerRegistry/_workitems/edit/24778096](https://msazure.visualstudio.com/AzureContainerRegistry/_workitems/edit/24778096)# --- In reply to: [1666239285](https://github.com/Azure/azure-rest-api-specs/pull/24771#issuecomment-1666239285) [](http://example.com/codeflow?ancestors=1666239285) --- Refers to: specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json:268 in 2f24e4f. [](commit_id = 2f24e4fd0275eb41cc31384478a4ed569a7a0b50, deletion_comment = False)

> }, LRO-Delete does not need 200 --- Refers to: specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json:479 in 2f24e4f. [](commit_id = 2f24e4fd0275eb41cc31384478a4ed569a7a0b50, deletion_comment = False)

> "provisioningState": { duplicated with that in "CacheRuleProperties". Consider defining a common model #Resolved --- Refers to: specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json:2804 in 2f24e4f. [](commit_id = 2f24e4fd0275eb41cc31384478a4ed569a7a0b50, deletion_comment = False)

> "AuthCredential": { please double check to use x-ms-secret for credential properties [https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-secret](https://github.com/Azure/autorest/blob/main/docs/extensions/readme.md#x-ms-secret) #Resolved --- Refers to: specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json:2883 in 2f24e4f. [](commit_id = 2f24e4fd0275eb41cc31384478a4ed569a7a0b50, deletion_comment = False)

> "201": { LRO-Patch should use 200 and 202 --- Refers to: specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json:265 in 05a2ef1. [](commit_id = 05a2ef1a79e67477beb5a3e184559379849655ad, deletion_comment = False)

> "201": { same as above --- Refers to: specification/containerregistry/resource-manager/Microsoft.ContainerRegistry/stable/2023-07-01/containerregistry.json:541 in 05a2ef1. [](commit_id = 05a2ef1a79e67477beb5a3e184559379849655ad, deletion_comment = False)