sad icon indicating copy to clipboard operation
sad copied to clipboard

Avoid unnecessary line break at end of files; EOL type detection

Open Frederick888 opened this issue 3 years ago • 5 comments

When the original file hasn't got a line break at the end, we shouldn't insert one, either.

And additionally along with the fix above, we should detect if the original file uses CRLF or LF. CR is not supported.

Closes #48.

Frederick888 avatar Jan 29 '21 16:01 Frederick888

thanks but i cant merge this until i pull out async-std and replace the channels with their separate package, or else it wont compile anyways

😔

been focusing on other projects recently so this might take a few says

ms-jpq avatar Jan 29 '21 16:01 ms-jpq

@ms-jpq Sure if you have other projects to work on atm, just merge this one when you've got time to clear out the blockers. I can easily patch this locally :)

Frederick888 avatar Jan 29 '21 17:01 Frederick888

ok i solved all the dependency issues, this one is next

ms-jpq avatar Feb 17 '21 05:02 ms-jpq

https://github.com/ms-jpq/sad/commit/88036cd32f1305a570a0b1603f2ef11857dddcda

I fix it

ms-jpq avatar Jun 20 '21 20:06 ms-jpq

One more issue is maybe rust doesnt split '\r' on '\n', but I gotta do stuff so I guess thats for tomorrow

ms-jpq avatar Jun 20 '21 20:06 ms-jpq