coq_nvim icon indicating copy to clipboard operation
coq_nvim copied to clipboard

Breaking change :: [ Function] in your popup menu -> Please READ

Open ms-jpq opened this issue 2 years ago • 17 comments

If you see

图片


Solution

Either set let g:coq_settings = { 'display.icons.mode': 'none' } to disable icons, or install a supported font.

ms-jpq avatar Aug 31 '21 00:08 ms-jpq

I added Icon support, and decided to try my luck turning it on by default.

🐸


If you turn off the icon support, it goes back to same as before, and if you install the fonts:

icons.png

ms-jpq avatar Aug 31 '21 00:08 ms-jpq

I am seeing this issue here. We need a space after the icons for when no subtext to it's not juxtaposed next to the ]

image

beauwilliams avatar Sep 02 '21 00:09 beauwilliams

EDITED:


coq_settings.display.icons.spacing

How many of padding to use after icon.

Increase this if your icons are too close to each other.

default:

1

ms-jpq avatar Sep 02 '21 02:09 ms-jpq

@beauwilliams please set coq_settings.display.pum.kind_context to [" [", " ]"], or whatever you want it to be.

I think like for different fonts, the spacing is different? so its probably easier to adjust the brackets than all the icons.

edit: the default is [" [", "]"], missing the space

Sure thing, thanks for the help and I can add that in no drama.

Should we change the default however?

beauwilliams avatar Sep 02 '21 02:09 beauwilliams

wait i had a brain fart, sorry what i said cannot fix it for you, its in the wrong direction, derp.

ill make a pr to fix it for u

ms-jpq avatar Sep 02 '21 02:09 ms-jpq

https://github.com/ms-jpq/coq_nvim/pull/198


coq_settings.display.icons.spacing

How many of padding to use after icon.

Increase this if your icons are too close to each other.

default:

1

ms-jpq avatar Sep 02 '21 02:09 ms-jpq

Good news is the new option works. But it seems I still have the same issue for the BUF type

error

beauwilliams avatar Sep 02 '21 09:09 beauwilliams

If we don't ever have anything but text for the buffer completion type. We could just have it say [aA Text] like the lsp completion at the top there, or add a space when nothing is returned next to the icon

beauwilliams avatar Sep 02 '21 09:09 beauwilliams

sorry please try it now.

ms-jpq avatar Sep 02 '21 09:09 ms-jpq

yep its fixed with latest pull if I set spacing to 2 👍

beauwilliams avatar Sep 02 '21 10:09 beauwilliams

is it possible to only show the icon, and hide the text description? the redundancy is kind of unnecessary

elkowar avatar Sep 11 '21 12:09 elkowar

yes, please see https://github.com/ms-jpq/coq_nvim/blob/coq/docs/DISPLAY.md

ms-jpq avatar Sep 12 '21 03:09 ms-jpq

coq_settings.display.icons.mode -> short

ms-jpq avatar Sep 12 '21 03:09 ms-jpq

I'm trying the option let g:coq_settings = { 'display.icons.mode': 'none' } but it's not working.

matheusAMDS avatar Sep 26 '21 03:09 matheusAMDS

@ms-jpq Short is buggy too. I'm using nerd fonts.

mkubasz avatar Oct 14 '21 15:10 mkubasz

This is my solution display = { icons = { mappings = { Text = "", Method = "", Function = "", Constructor = "", Field = "ﰠ", Variable = "", Class = "ﴯ", Interface = "", Module = "", Property = "ﰠ", Unit = "塞", Value = "", Enum = "", Keyword = "", Snippet = "", Color = "", File = "", Reference = "", Folder = "", EnumMember = "", Constant = "", Struct = "פּ", Event = "", Operator = "", TypeParameter = "" } } }

mkubasz avatar Oct 14 '21 15:10 mkubasz

let g:coq_settings = { 'display.icons.mode': 'none' } seems to have no effect for me either. I still see icons. I call it before calling require('coq'). The plugin otherwise works perfectly.

Edit: I gathered from #292 that adding the following to the Lua configuration, before require('coq'), works:

vim.g.coq_settings = {
  display = { icons = { mode = 'none'} }
}

I no longer see icons.

maxwelljens avatar Feb 05 '22 23:02 maxwelljens