docile
docile copied to clipboard
TEST: support ruby 3.3 NoMethodError message
ruby 3.3 changes error messages especially for NoMethodError: https://github.com/ruby/ruby/pull/6950 https://bugs.ruby-lang.org/issues/18285
Modify spec to support this new ruby 3.3 error messages.
Closes #105 .
Codecov Report
All modified lines are covered by tests :white_check_mark:
Comparison is base (
08cf67d) 100.00% compared to head (43e851b) 100.00%.
Additional details and impacted files
@@ Coverage Diff @@
## main #106 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 94 94
=========================================
Hits 94 94
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hey @mtasaka, I just found this PR while working on a project which uses this gem, I agree with your changes, it would be great if we could have this merged and released so docile could officially support Ruby 3.3.
@ms-ati what do you think?
Sorry for the delay on this, I agree with this simple fix and will try to get a release out
Thank you for merging this change!, and also thanks to @mtasaka for creating the PR! 😄 also, on second thoughts, do you think a new release is really necessary? for this changes only affect tests.
Actually if you don't think the release is necessary, I can create a PR to add to the changelog the info that now 3.3 is officially supported.
v1.4.1 has been released which includes Ruby 3.3 support