fix: form select set wrong `label` value on `value` prop

[weiliang79]

Pull Request

Description:

Fixed FormSelect component setting label value on value prop.

Tested Platforms:

• [ ] Docs
• [ ] Web
• [ ] iOS
• [ ] Android

Summary by CodeRabbit

• Bug Fixes
  • Updated the way selection values are processed in forms, ensuring that the displayed value accurately reflects the actual input without duplicating labels.

[vercel[bot]]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
rnr-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 20, 2025 7:28am
rnr-showcase	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 20, 2025 7:28am

[coderabbitai[bot]]

Walkthrough

The change updates the value assignment in the FormSelect component. Instead of passing an object containing both label and value derived from value?.label, the Select component now receives the value directly from value?.value (or an empty string if undefined). This ensures that the intended value is used without duplicating the label.

Changes

File	Change Summary
packages/reusables/.../form.tsx	Updated the value prop in the FormSelect component: now using value?.value ?? '' instead of using value?.label.

Poem

I'm a rabbit, hopping with delight,
Tweaking the code from morning to night.
From labels to values, pure and clear,
My tiny paws cheer with a joyful cheer!
Happy hops and clean code, oh what a sight!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI Review profile: CHILL Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 353ee5e45dc2cd04b078e5d83c584c34fbc65e0e and 0e53255ee6cc47e90559a0fd8c56978345b1cec4.

📒 Files selected for processing (1)

• packages/reusables/src/components/ui/form.tsx (1 hunks)

🔇 Additional comments (1)

packages/reusables/src/components/ui/form.tsx (1)

529-529: Bug fix correctly implemented.

The change fixes the issue where the FormSelect component was incorrectly using value?.label for both the label and value properties. Now it properly uses value?.value for the value property, ensuring the correct data is passed to the underlying Select component.

✨ Finishing Touches

• [ ] 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[mrzachnugent]

Hey @weiliang79 , thanks for contributing. Unfortunately the form component was removed. @gabimoncha is working on a community form component made with components from the React Native Reusables registry.