react-native-reusables icon indicating copy to clipboard operation
react-native-reusables copied to clipboard
verified publisher icon mrzachnugent

[ BUG ] Dialog not closes on outside click, close button not working.

Open kerimovok opened this issue 1 year ago • 2 comments

kerimovok avatar Oct 06 '24 11:10 kerimovok

Hey @kerimovok, please provide a minimal reproduction repo as I am unable to reproduce this issue.

mrzachnugent avatar Oct 06 '24 17:10 mrzachnugent

Steps to reproduce:

  1. Create Expo project
  2. Add the Dialog component manually as shown in docs for native only
  3. Add code example from docs and test on mobile device

I tried some props on DialogOverlay, but still not working, close button also not working

Tested on: iOS 17 iPhone X

Thank you for project

kerimovok avatar Oct 06 '24 19:10 kerimovok

This (click outside to close) is actually not working on the demo page: https://rnr-showcase.vercel.app/alert-dialog

Also there's no close/exit animation, curious if this is a limitation of the implementation or if its a bug

kaumac avatar Oct 16 '24 06:10 kaumac

@kaumac That is desired behaviour. See https://ui.shadcn.com/docs/components/alert-dialog for reference. As for the animations, it seems like a bug.

mrzachnugent avatar Oct 16 '24 13:10 mrzachnugent

thanks for clarifying that @mrzachnugent

The animation issue seems to be project wide. The same happens with the tooltip component. I'll create a separate issue for this.

kaumac avatar Oct 17 '24 17:10 kaumac