photoframe icon indicating copy to clipboard operation
photoframe copied to clipboard

Python3

Open mrworf opened this issue 4 years ago • 8 comments

Ongoing work to migrate to Python3 while remaining compatible with the python3 that's part of the SD card image for photoframe. Once this works reliably, the plan is to prepare a new SD card image which uses python3 by default (and a much newer distro version). @dadr 😄

mrworf avatar Feb 23 '21 19:02 mrworf

Another item on my list is adding test coverage to avoid breaking people's frames with an update :) But we'll see, since it's A LOT of code to test, even if just tox coverage

mrworf avatar Feb 23 '21 21:02 mrworf

Wow! You can imagine my surprise when I read the email about this PR. It's a major step for sure. I'll try kicking the tires too! ;-)

dadr avatar Feb 23 '21 21:02 dadr

Well, I got inspired by the activity and I also got hold of my dev frame that sat at work before so I can more easily do some testing now. My main frame is RPi3 and the dev frame is RPiZ to make sure I don't mess people up 😸 .

Feel free to review and/or use this version and submit feedback. I also need to work on the update script so it can upgrade people's frame with the correct Python3 modules.

mrworf avatar Feb 23 '21 21:02 mrworf

MIGRATION.md should hold the changes you need to do to your RPi setup to allow this to run.

mrworf avatar Feb 23 '21 21:02 mrworf

Loads of great news Henric,

Thank you for the amazing work !

Rafik Sent from my iPhone

On 23 Feb 2021, at 21:56, Henric Andersson [email protected] wrote:

 Well, I got inspired by the activity and I also got hold of my dev frame that sat at work before so I can more easily do some testing now. My main frame is RPi3 and the dev frame is RPiZ to make sure I don't mess people up 😸 .

Feel free to review and/or use this version and submit feedback. I also need to work on the update script so it can upgrade people's frame with the correct Python3 modules.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.

rafik24 avatar Feb 23 '21 21:02 rafik24

I found MIGRATION.md already. (might format as code, as I did a rookie mistake in cut and paste without noticing that there were 2 lines for pip and not one.) I have a 1A, 3B, and Zw. (plus the PC).

In any case - thanks and regards.

dadr avatar Feb 23 '21 22:02 dadr

Oups, yeah, it's my notes for what I need to do to get this running. Will be formatted properly before merge, promise 🤞 😆

mrworf avatar Feb 23 '21 22:02 mrworf

Added the new version of the update script. Allows segmented updating, meaning that as new versions require changes to the installation, they will be done, but it tracks what it has done and thus is a bit safer longterm than existing solution.

Will have to do some testing before that can be deemed ok. Also solved some flake8 errors/warnings.

mrworf avatar Feb 26 '21 06:02 mrworf