dx11-vvvv-girlpower
dx11-vvvv-girlpower copied to clipboard
mrvux
Camera fixes
Dear mr. Vux,
here are some fixes for the helppatches and the girlpowers. Most of the fixes are getting rid of the Legacy Camera, some of them have other little cosmetics.
Waiting for getting this request accepted in order to provide two more requests with Addition and Changes.
Best, Anton
Ok quite a few things, since that is pretty hefty:
This is introduced in (almost) everywhere. <PACK Name="dx11" Version="33.0"></PACK> Is it automatic? Or does it needs manual update all the time? Also sometimes it's modified, sometimes just removed, sometimes added, seems quite a bit too random.
Has all that pack diffing got tested properly?
Still could this pull request being split into pieces?
there's way too many changes and things to consider here to review to have that accepted in a short period of time.
Dear mr. Vux,
Regarding the removed pack versions: Since in your packs so far you have never distributed a version.info file the pack version was never used. So now it is only consequent to get rid of all those references. that is why you see all those removes.
Should you ever decide to include a version.info which will allow you to do node/pin-renames from one release to the next, here is how: https://vvvv.org/blog/patch-conversions-pack-versioning
Regarding splitting the pullrequest please let us know how you'd prefer it before we start. Would you accept one PR for all files in \girlpowers and another for all help-patches in \nodes?
Best, Anton
Well I think there's been a little bit of misunderstanding here.
In some updates there was a red camera node (literally trying to load legacy camera, as written), I wanted this camera to be fixed, not having every camera of every module updated to 35 version (specially since minimum supported version is 33.7)
About versioning, that requires a rather large amount of testing, so better to have it in a separate pull request. I don't really suddenly start to have random bits versioned and others not (the pull request kinda tends on this aspect), so that should be a full task on it's own.
About modules updates, separate pull request as well (per module unless one depends on another)