Michael Ruoss
Michael Ruoss
Thanks for the review @jonatanklosko > 1. It would be great if we could add an integration test (against a local cluster) for the runtime itself, similar to `test/livebook/runtime/fly_test.exs`. This...
@jonatanklosko I've added an integration test now. I've also added it to the CI because I think this really helps to catch regression. However, it does slow down the pipeline...
OK I will remove it from CI again. Can always put it back later. Also possible in a different pipeline that runs under different conditions.
I think it's only UI tests left now. Have to find a good way to mock the kubeconf setup first. Mocking the req should then be straight forward...
> @mruoss honestly I think it's fine to skip it on CI. @jonatanklosko It looks like `kind` is installed on those GH runners which makes the test run automatically. Shall...
@jonatanklosko @josevalim I've added integration and UI test and feel pretty confident now regarding regression. So I think this is ready for a final review. I guess the changelog entry...
Have removed `yaml_elixir` from the deps.
@dependabot rebase
@dependabot rebase
is there a way to work around this bug?