Martin Zlámal

Results 29 comments of Martin Zlámal

Hi @brunobmello25, I found your issue because I had the same problem and after some more searching I found this which fixed the problem for me (I had to disable...

I'd like to support this proposal as well. Using `JSXNamespacedName` like `fbt:param` seems to be quite unconventional (even though [valid](http://facebook.github.io/jsx/)) and it causes issues in various places like this one...

I have another example where `` caused an issue: https://github.com/yannickcr/eslint-plugin-react/issues/3080 Basically, there was a breaking change in `eslint-plugin-react` where they started ignoring lowercased JSX tags and as a consequence `no-unused-vars`...

@Brianzchen such consistency can be already achieved with `prettier/prettier` rule (Prettier [already takes care of the consistency](https://prettier.io/playground/#N4Igxg9gdgLgprEAuEMCeAHOACACgJwgwGdsBebYAHSm2wGoBLYgEWYEMAjAGzgBMk2ThAi92UANw06TYgFEoXXgKEixUADQ0AviA0giMRtGLJQ7fIQDuuCwlMp23K+zSn9nfOzABrODABlDG9GKABzZBh8AFc4fTgAW05+Pn4AGXEw6PYwuAAxCHwE9hgjcOQQdmiYCD0QAAsYBO4AdXrGeGJgsDgA+w7GADcOtAqwYncQUOI4fBgCHOLkADMnGf0AK2IADwAhL19-APYEuDTQuBW1uJAt7YDQsN4ARWiIeCvudZBg-Bn8CqcLhwbh1DD4UIwFqMPgwerIAAcAAZ9OCIDMWl4MBVwXB-oNLvoAI5veAEIgOSrEAC0UDg-H4dXwcBJjGZCzCSyQqy+NxmCUYkRifMeL1Jl25130MC40Nh8KQACZpV5GNxHgBhCAJLkgPEAVjq0RmABUuA4ed9BrEAJJQVKwAJgCEYGAAQXtAXQvE+M202iAA)). It's true that it forces to use `,` instead of `;` though and...

Makes sense. 👍 > Could we just duplicate that rule here? I don't think that's easily possible. I'd expect that the Eslint rule calls Prettier directly and just reports back...

This issue seems to be fixed in the newly released descendant of this plugin: https://github.com/flow-typed/eslint-plugin-ft-flow

I think this issue could be closed. More complex custom scalars are already supported. Configuration: https://github.com/facebook/relay/blob/dec019d3290233e134b603124001814a77832271/scripts/config.tests.json#L23-L25 Implementation: https://github.com/facebook/relay/blob/2768c3ea12668c5bf23d47d51515bd3939f9543f/packages/relay-runtime/mutations/__tests__/OpaqueScalarType.js#L15-L30

@LukasKalbertodt, I do not have more info. But maybe @captbaritone?

WOW! I just discovered that these new Flow types are directly supported by Flow! 🤯 So it seems like the expected way how to use Relay with Flow is to...