Daniel Schauenberg

Results 71 comments of Daniel Schauenberg

Hey thanks for the pull request! If I understand correctly, this is basically just metrics naming cosmetics presumably for Graphite? In that case it would make much more sense to...

right it's the function for internal metrics processing. I was just thinking about whether naming metrics should even be a concern of the processing part or if it makes more...

Interesting patch, do you see any downsides of this just being the normal behaviour? I don't think connecting without any metrics is useful in any situation. So if you can't...

Hey is this synced with the changes in #364 ? Or do we need to sync both up to merge this?

There are a couple of things to note here. First, in this scenario ``` |--UDP--> STATSD1 -UDP-> GRAPHITE-BACKEND-1 | APPLICATION ----| | | | |-TCP--> REPEATER-BACKEND-1 --> STATSD-EXPORTER |--UDP--> STATSD2...

I think removing global vars is definitely a good thing. I'm not sure I get the benefits of the inheritance approach. It seems to add some more boilerplate to creating...

Can you give a good use case for this? It feels like it's making the storage paths much more confusing, especially since you can easily do wildcard matching in graphite.

Thanks for the pull request, the changes look good. Can you add the new configuration bits also in `exampleConfig.js` and move them under the `graphite` key? I know it's not...

I think this change makes sense in general, however I'd much rather have a less hacky version where we correctly set the prefix when building up the strings and not...

@ykyuen we are not yet running a proxy setup. However I would go about measuring how much traffic you get on there and then tune the number of StatsDs accordingly....