checkmake icon indicating copy to clipboard operation
checkmake copied to clipboard

False positive .PHONY violation on variables

Open dgeorge83616 opened this issue 3 years ago • 0 comments

https://github.com/mrtazz/checkmake/blob/ca982aef0af387413edc4b515880bef071730dea/parser/parser.go#L48-L49

Those regex definitions don't recognize VAR=blah or VAR:=blahand flag such lines as needing.PHONY`.

    1 ifeq ($(OS), Windows_NT)
>>  2 MKDIR:=$(shell which mkdir.exe)
    3 else
~   4 MKDIR := mkdir
    5 endif

dgeorge83616 avatar Nov 19 '21 23:11 dgeorge83616