webpack-svgstore-plugin icon indicating copy to clipboard operation
webpack-svgstore-plugin copied to clipboard

3.0.1 and 3.0.2 broke being able to find svg asset

Open roastlechon opened this issue 8 years ago • 9 comments

usage code:

import svgxhr from 'webpack-svgstore-plugin/src/helpers/svgxhr';
import React, { PropTypes } from 'react';

const __svg__ = {
  path: './svg/**/*.svg',
  name: '/images/svg/[hash].icon.svg'
};

svgxhr(__svg__);

Network panel on dev tools and server shows:

/images/svg/[hash].icon.svg 500 14.228 ms - -

roastlechon avatar Aug 01 '16 18:08 roastlechon

Hi @roastlechon thx for issue. I'll see your report right now.

mrsum avatar Aug 02 '16 08:08 mrsum

@roastlechon could you fix on 3.0.0 version, i'll let you know when bug will fixed.

mrsum avatar Aug 02 '16 09:08 mrsum

@mrsum Sorry it's my fail, i check previous commit (Long term caching) in build time and it's work, but in webpack dev server i have same issue as above.

matpaul avatar Aug 02 '16 09:08 matpaul

@matpaul Don't worry about it ) I'll fix ASAP

mrsum avatar Aug 02 '16 09:08 mrsum

@mrsum Big Thx!

matpaul avatar Aug 02 '16 09:08 matpaul

@roastlechon @matpaul Guys, i've spent all day and best decision what i took is revert to version without caching support.

I've bring back 3.0.0 version as 3.0.3 cause i cant unpublish them. So, i'll back soon for resolving https://github.com/mrsum/webpack-svgstore-plugin/issues/98

mrsum avatar Aug 02 '16 16:08 mrsum

Thanks for the quick reply/discussion @matpaul @mrsum. I fixed on 3.0.0 in my package.json.

roastlechon avatar Aug 03 '16 02:08 roastlechon

@mrsum any updates ?)

matpaul avatar Aug 12 '16 11:08 matpaul

@matpaul I finished for long-term caching support https://github.com/mrsum/webpack-svgstore-plugin/blob/feature/long-term-caching/src/svgstore.js

after testing, will publish new release in next few days

mrsum avatar Aug 23 '16 15:08 mrsum