dotenv-webpack icon indicating copy to clipboard operation
dotenv-webpack copied to clipboard

feat: compatible with rspack

Open ahabhgk opened this issue 1 year ago • 1 comments

Use compiler.webpack.DefinePlugin instead of require from webpack, this is also available way in webpack, and can be compatible with rspack.

This can also avoid requiring wrong webpack when using monorepo and have multiple webpack in node_modules

ahabhgk avatar Oct 11 '23 08:10 ahabhgk

and this is more friendly to monorepo

hardfist avatar Dec 18 '23 07:12 hardfist

hi @mrsteele sry for ping you, but it seems that this pr is ready for merging. Could you please help merge and release a new version?

xc2 avatar Mar 18 '24 07:03 xc2

Any chance you ran tests? I want to make sure it’s compatible with previous versions of webpack/node.

mrsteele avatar Mar 18 '24 17:03 mrsteele

Didn't notice webpack4 don't have compiler.webpack. Fixed it and now it should compatible with webpack4, and all tests pass in my local

ahabhgk avatar Mar 19 '24 06:03 ahabhgk

:tada: This PR is included in version 8.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket:

github-actions[bot] avatar Mar 22 '24 03:03 github-actions[bot]

thank you all @ahabhgk @mrsteele

xc2 avatar Mar 22 '24 04:03 xc2