Mark Hughes
Mark Hughes
Just a quick update on this one - we're using it quite effectively ourselves so I'll tidy this up (hopefully early next week) with some tests and examples to make...
I know I never came back to this one - in the end, we ended up sticking with more idiomatic godog 'return an error' directly instead of using testify's require/asset...
@b0ch3nski what is here does work, we're using it pretty heavily - but mostly just for the contextual logging in the output, we moved away from using testify as it...
> @mrsheepuk I have kind of opposite feeling that reimplementing everything that `testify` already does just to return errors is fighting against an idiomatic way of doing things :thinking: Oh,...
Just an update - I'm going ahead and adding some test coverage over this and tidying it up to implement as much as makes sense of testing.T's public interface, so...
@b0ch3nski - would you be interested in trying to use this branch to validate if it meets your needs? I've added some tests and tidied up the code a bit.
@b0ch3nski I've updated the godog-assert example and renamed 'GetTestingT(ctx)' to 'T(ctx)'. @vearutop are you someone who can cast an eye over this from a maintainer perspective? or is there someone...
hi @vearutop - just a quick update, I improved the test coverage and updated the README and CHANGELOG so I think from my perspective, this is ready to go assuming...
> I've commented a couple of minor things, and then I think this is good to merge. 👍 Thanks for the review @vearutop - updated and ready for another try...
I had the same issue last week when I tried... we should send them a slack message about it... 😆