mrousavy
feat: Added option to consider ringer mode in Android
What
When using the takePhoto function in Android, ringerMode is not applied by default, but is applied when a value is received as an option
If isAppliedRingerMode option is set to true in takePhoto function, When ringerMode is RINGER_MODE_NORMAL, the shutterSound option is applied. When the ringer mode is RINGER_MODE_SILENT or RINGER MODE VIBRATE, the shutter Sound option is ignored.
Changes
Tested on
Related issues
The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| react-native-vision-camera | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 27, 2024 5:31am |
![vercel[bot] avatar](https://avatars.githubusercontent.com/in/8329?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hey - thank you for your contribution, this is much appreciated. I always prioritize PRs over issues to discuss such things.
In this case, I think the prop can be a bit confusing. The naming, especially combined with the description, isn't very obvious.
I think that the current behaviour is perfectly fine - it is exactly how it is on iOS. When the phone is on silent, we don't want any sound. What is your use-case that you need shutter sound anyways? Is that really what users expect to happen?
